Srikanth Chekuri

Results 417 comments of Srikanth Chekuri

@legendecas yes, that's why I didn't use _fixes_ in the PR description that would close this issue. And there is also tiny env related work to do. I will work...

@pichlermarc I won't be able to allocate time for this - unassigning myself. Thanks.

You are correct about the identity part - updated the description. And as you know we don't have `get_logger` similar to `get_{tracer,meter}` since we don't have the API and it's...

@ocelotl is that a valid pylint usage? Can you disable pylint for class like that?

This looks like a legitimate bug. I haven't gotten time to triage this. I will check.

Just to reiterate, this exporter exists for debugging purpose only and in that context I think it make sense to show the way it is shown instead of plain number...

@ocelotl are you planning to add the API package that includes things like `LoggerProvider` and `Logger` interfaces, and global setter and getter providers in follow-up PR(s)?

Renaming is only part of it but the spec now has the logs API as well https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification/logs

Thanks for the report. It looks like sending a sampling header alone is a common practice in [Zipkin eco](https://github.com/openzipkin/b3-propagation#overall-process). This should be handled [here](https://github.com/open-telemetry/opentelemetry-python/blob/main/propagator/opentelemetry-propagator-b3/src/opentelemetry/propagators/b3/__init__.py#L89-L104). Feel free to send a fix...

You are trying to return an empty context because `sampled`=0 would not in `_SAMPLE_PROPAGATE_VALUES`={"1", "True", "true", "d"}. It should return context with invalid root span and default trace flag (0).