Serhii Khoma comments

Results 186 comments of


                                            Serhii Khoma

Style block still exist even uncheck "Don’t remove <style> and <link> elements"

https://github.com/fphilipe/premailer-rails/issues/192

Ligatures request: /\ and \/

also it should work even when surrounded by spaces e.g. there is an issue in `https://github.com/tonsky/FiraCode/issues/1013`

> They was removed exactly because they looked wrong in regexps. [#78 (comment)](https://github.com/JetBrains/JetBrainsMono/issues/78#issuecomment-578710304) hi, well, I understand, but maybe it can be ligated only when surrounded by whitespace OR start/end...

Proposal: inline/optimize out aliases of unsafeCoerce

@hdgarrood what other examples you have in mind?

fix(#668): appendChild is called thought there is no need to call it except for root component

@thomashoneyman oops, I unintentionally added extra commit, fixed

fix(#668): appendChild is called thought there is no need to call it except for root component

@thomashoneyman tnx for pushing it NB: as an alternative approach we can split the `render` function from spec on `renderChildComponent` and `renderRootComponent`

appendChild is called thought there is no need to call it except for root component

This cat be resolved by: 1. Add `isRootComponent` to the driver spec and append if it is true Or 2. Do this in the runUI runComponent function But this would...

appendChild is called thought there is no need to call it except for root component

Oops

Make the compiler package aware

related discussion https://discourse.purescript.org/t/the-only-thing-i-hate-in-purescript-and-haskell-imports-discussion/1700