Serhii Khoma

answer on https://github.com/purescript-halogen/purescript-halogen-vdom/pull/38#issuecomment-629367556 ok, I agree that it's not good to change the name of arguments on this stage but what about: - adding types - adding comments - adding...

I have noticed @thomashoneyman mentioned that [during halogen v5 refactoring the](https://github.com/purescript-halogen/purescript-halogen/pull/654/files#diff-b7a517a3167635396bddd58607af76c6R576) ``` The type variables have been renamed to full words in the component / query / etc. type signatures....

also, halogen is using long arrows everywhere `->`, halogen-vdom is using unicode arrows everywhere `→`

@natefaubion plz)

elm implementation https://github.com/elm/virtual-dom/blob/master/src/Elm/Kernel/VirtualDom.js#L1531 react implementation https://github.com/facebook/react/blob/43063fd8442c5dfa927b4cc423bae1bdbeac7132/packages/react-dom/src/client/ReactDOMLegacy.js#L256 e.g. here warning for text difference https://github.com/facebook/react/blob/823dc581fea8814a904579e85a62da6d18258830/packages/react-dom/src/client/ReactDOMComponent.js#L1072 also warned for extra attributes https://github.com/facebook/react/blob/823dc581fea8814a904579e85a62da6d18258830/packages/react-dom/src/client/ReactDOMComponent.js#L222 warnForPropDifference

I have found that prerendered html should not contain any newlines because with ``` test label 1 test label 2 ``` `componentNode.childNodes` will return newspaces too the correct version is...

> I would appreciate it if we could avoid major refactors. It makes it difficult to audit what has actually changed. ok, moved only refactoring changes to https://github.com/purescript-halogen/purescript-halogen-vdom/pull/39

I have reverted #b385b50 in commit https://github.com/purescript-halogen/purescript-halogen-vdom/pull/38/commits/c17301b531100e1d55e6c7c73516b9e1ef49c563

@natefaubion @thomashoneyman @garyb The pr is ready it is in sync with https://github.com/purescript-halogen/purescript-halogen/pull/671 I have tested it using this project https://github.com/srghma/purescript-halogen-nextjs/ that is using a copy of examples from halogen,...

> modify existing items that have changed slightly no, it will throw error IF dom doesnt match vdom in future would be good to do this check in development, but...