Stephan Renatus
Stephan Renatus
I see. Hmm given that we cannot overload functions, what would you call this? `graphql.schema_valid`? Is this something you could see yourself contributing? 😃
Oh contributors of every experience levels are welcome here. If you'd like a challenge, we're here to help. Just holler and we'll get you some pointers on which steps are...
> but directed it to the gqlparser gitHub you use as mirror 👍 thanks, good call!
We're using v2.4.8, I think, based on https://github.com/open-policy-agent/opa/pull/5067. Yeah feel free to open a PR, we'll get the DCO sorted out, it's just a matter of adding a Signed-off-by line...
Huh. I would have expected that it would be cool to just ad the ValidateSchemaDocument call to the existing `parse_schema` builtin. WDYT @philipaconrad?
Also if it can be helped, let's try to do one thing at a time. I don't think we need to bump the version for being able to use ValidateSchemaDocument,...
😳 Looks like I've missed that this PR had seen some action. I'll have another look soon. Please bear with me!
Thanks for the hand-over and thanks for picking this up. Since it'll be a new PR anyways, I'll close this one. @iamatwork good luck with your next steps! 🤞
@philipaconrad I've put it into the backlog; that way, it won't get picked up (and picked on) by the stale bot.
👀 It looks OK-ish, but I wonder if we couldn't make the RequestID part of the decision struct (`*server.Info`).... putting values on the context always feels a tiny bit underhanded...