opa icon indicating copy to clipboard operation
opa copied to clipboard

decision log drop rule

Open iamatwork opened this issue 1 year ago • 3 comments

other half of #5043

this solves https://github.com/open-policy-agent/opa/issues/3945

drops events before logging decision, if the drop rule evaluates to true

e.g. drop all granted requests

package system.log

drop {
  input.result
}

New configuration option

decision_logs
  drop_decision: "/system/log/drop" (default)

iamatwork avatar Aug 25 '22 18:08 iamatwork

😳 Looks like I've missed that this PR had seen some action. I'll have another look soon. Please bear with me!

srenatus avatar Sep 20 '22 13:09 srenatus

Hello @srenatus,

I did a small change to use the Allow-method, but not much more. We had a very sudden and painful reorg. I'm not sure, if I'll be able to much more for this PR. :-( I'll know more next week. I'll try to get it done, if I find some spare time. But I'm busy with my new tasks, and looking for a new job atm.

iamatwork avatar Sep 20 '22 13:09 iamatwork

Sorry to hear that, @iamatwork 😞 I hope that situation is resolved as soon as possible! Let us know once you know if you'll have time to finish this, or we can try and add the last missing pieces so that we can have it merged.

anderseknert avatar Sep 21 '22 06:09 anderseknert

@iamatwork sorry I pinged you in a different PR that was merged. I actually ment this one, do you mind if we pick it up?

johanneslarsson avatar Oct 03 '22 11:10 johanneslarsson

@iamatwork sorry I pinged you in a different PR that was merged. I actually ment this one, do you mind if we pick it up?

I'd be happy, if you did. I don't have proper testing infrastructure anymore.

iamatwork avatar Oct 04 '22 10:10 iamatwork

@iamatwork sorry I pinged you in a different PR that was merged. I actually ment this one, do you mind if we pick it up?

I'd be happy, if you did. I don't have proper testing infrastructure anymore.

Thank you for replying. Best of luck with finding a new opportunity!

johanneslarsson avatar Oct 04 '22 11:10 johanneslarsson

Thanks for the hand-over and thanks for picking this up. Since it'll be a new PR anyways, I'll close this one.

@iamatwork good luck with your next steps! 🤞

srenatus avatar Oct 04 '22 12:10 srenatus