Sven Rebhan

Results 384 comments of Sven Rebhan

@powersj I agree, we should add a `Start()` and `Stop()` implementation, making this a mix between service and pull plugin.

Hmm looking a bit more into the issue, I cannot see how we should cleanup that connection. Furthermore, this API will only issue HTTP requests which should not keep an...

@smalenfant please test PR #15319, available as soon as CI finished the tests, and let me know if this fixes your issue! Please use the new `round_timestamp_to` option for manipulating...

@gangadharaswamy can please run `make docs` and fix the CI/build errors!?

Or even better use: `github.com/coreos/go-semver`...

> Hmm, okay, I think we should wait for @srebhan to come back on [#13034 (comment)](https://github.com/influxdata/telegraf/issues/13034#issuecomment-1507280841) first before going more into detail.. Why do we need to do this first?...

@dd-accedian can you please sign the CLA and let me know once you are done?!? We can only review and merge code where the author signed the CLA...

Thanks for the review and comments @powersj. Let me answer your points... > 1. What is the expected behavior when the state file does not exist? I see an info...

> I need to remind myself of how we review files, but off the top of my head is there a way we can keep the sha256 sum of the...

@knollet please open an issue for this and do not hide it in an "old" PR!