Sam Rawlins

Results 158 issues of Sam Rawlins

A casual search for `is InterfaceType` and `is! InterfaceType` yields a lot of results: ```none $ git grep 'is\(!\)* InterfaceType' | wc -l 9 ``` We should review these to...

P2
type-tech-debt

When documenting the flutter devtools app, (`flutter/devtools/packages/devtools_app`), I found that Tuple3 is one of the top memory-consuming classes, at 31.9 MB, across 696503 classes. We should research how we might...

P3
performance

There are many unused elements in scanner.dart. Also the return statement after `fail` is dead code, as `fail` is marked as `@alwaysThrows`.

iOS 11 and the iPhone X have the notch thing, and safe areas and all, which can be styled around using `env()` (or `constant()` in iOS 11.0 I guess). But...

I'm looking at proposed linters like #767 ("border value order"), #741 ("font-weight notation"), #733 ("disallow visibility:visible") and existing linters like BorderZero, Shorthand, TransitionAll, and I see a few problems: 1....

enhancement
question

It seems like EmptyLineBetweenBlocks should lint around `@if`, no? It currently doesn't: ``` bash $ cat -n a.scss 1 a { 2 margin: 1px; 3 @if (1 + 1 ==...

enhancement

I'm looking into ways to make scss-lint faster. If I were being rigorous this would include some more data [1]. One idea I have that is playing well with one...

enhancement

Work towards https://github.com/dart-lang/linter/issues/4859 There are libraries outside a `lib/` directory, which violate `implementation_imports`. This PR ignores all such violations. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and...

a: tests
tool
framework

Work towards https://github.com/dart-lang/linter/issues/4859 There are libraries outside a `lib/` directory, which violate `implementation_imports`. The fix here is to always add an 'ignore' exception, as the "implementation" being imported is the...

p: camera
platform-web

Child of #4881 `unreachable_from_main` walks all compilation units (parts) to determine an element's reachability (including public elements). If a macro application augments a class with a constructor and/or a method,...

P2