Sam Rawlins

Results 125 issues of Sam Rawlins

I think the CONTRIBUTING.md doc should mention benchmarking 😁 . In particular, I don't know how to benchmark an individual rule, as opposed to the benchmarking task that is done...

type-documentation
P3

**Describe the issue** I believe that use_function_type_syntax_for_parameters should fire on field formal parameters and super-parameters. **To Reproduce** This test case does not pass the unit tests: ```dart class C {...

set-recommended
false negative

I was looking at test cases in order to implement a quick fix for `null_check_on_nullable_type_parameter` but came across some test cases that surprised me. `Future` / `await p!`: ```dart Future...

type-question
set-core

**Describe the issue** As of Dart 2.14 (I think), you can use a generic function type (e.g. `void Function(T)`) as a type argument and as a bound. This opens up...

type-bug
false negative
set-core

Reproduction steps: 1. In a package which uses `withEnabledExperiments`, * at a point in time when the latest dev build of the Dart SDK is numbered, e.g. 2.10.0-dev..., and *...

For instance how would I revive the default value of `c`? ```dart class A { void m([C c = const C()]) {} } class C { const C(); } ```...

I am encountering code in mockito, generating code which includes a class which implements a method called `List`. I think this is a method defined in proto-generated services. In any...

type-enhancement

See comments at https://github.com/dart-lang/code_builder/pull/275 for details.

type-bug

It's already in the transitive deps. The matcher package is not the full test API, but would allow people to play with test expectations in DartPad via `print(foo.matches(bar))`, etc.

p2
suggested-package
package-to-include

animations animations animations!

suggested-package
package-to-include