Sam Rawlins

Results 850 comments of Sam Rawlins

I don't see how the ignore list would allow consumers to catch up? Wouldn't it just hide all lint reports that they should be catching up on?

(Also, for google3 we have custom whitelisting mechanisms for times when Dart adds swaths of new static analysis reports)

I might be missing a lot of context here. What is the lint request? Is it just for this quiver function? Or is it generatlizable? Can we just change quiver's...

> IMO this is a generalizable problem that can be solved with (1) or (2) in all cases. I would prefer we don't implement this with (3). I agree; (1)...

I think this would be a special case we'd have to hard-code into the linter. The type of that callback is `Function`, since we don't have union types. The real...

> I can see that we [check whether to insert an implicit call reference](https://github.com/dart-lang/sdk/blob/d0a60d67c9820d0a146f48adf0c1111b87e840f8/pkg/analyzer/lib/src/generated/resolver.dart#L989), however the contextType argument is always null, and the parent won't be an AssignmentExpression, so it...

> Is it possible there is a bug that is causing some implicit call tearoffs to not be represented? Most definitely, since it's not used a lot in the wild.

> In what situation would you expect it to be non-null? When I see this method hit in the code I'm parsing I only have seen null. I would expect...

CC @leafpetersen who filed the initial lint rule request CC @a14n who implemented the lint rule CC @goderbauer in case this affects the decision to add this to lints/recommended.yaml as...