Sam Rawlins comments

Results 850 comments of


                                            Sam Rawlins

[flutter_markdown] Remove TaskListSyntax and rely on markdown native checkbox support - Fixes https://github.com/flutter/flutter/issues/107871

Note: the Ordered and Unordered task list item syntaxes are getting a big refactor soon. I don't _think_ it should be breaking, but note just in case: https://github.com/dart-lang/markdown/pull/450 After this...

[Proposal] Lint for 'safer' code

Without a more concrete description of what to report, I don't think we can act on this request.

False positive unrelated_type_equality_checks for certain generics cases

Hey now, I never said I _enjoyed_ working on unrelated_type_equality_checks. 😛

Avoid contravariant function fields

I think we can keep this open, if only as an approximate, partial, lightweight, supplemental linter rule to https://github.com/dart-lang/language/issues/214

use_build_context_synchronously and try/catch

CC @goderbauer

proposal: `prefer_extension_accessor_to_top_level_function`

Yeah I think I am mostly motivated to have the assist / quick-fix. I agree there is sort of no way to prove that codebases wouldn't be rife with false...

proposal: `prefer_extension_accessor_to_top_level_function`

> Should it apply to _getX and _setX as well, or is it only for public APIs? I think so, yes. > It could apply to static methods as well...

comment_references broken when using super parameters

I'm not sure.

Possible memory leak in use_late_for_private_fields_and_variables

There are no tests for the `part` support, so those will need to be added when a fix is made.

Possible memory leak in use_late_for_private_fields_and_variables

This support might already be broken. When I analyze these two files in an integration test: ```dart // library.dart: part 'part.dart'; int? _i2; // LINT // part.dart: part of 'library.dart';...