Marc R. Schoolderman
Marc R. Schoolderman
Hi! Thanks for requesting this. Could you open this as a separate issue? That makes it easier to track.
Thanks for the quick initial review! Note that the `tcp_connect` will eventually be completely removed as it's only part of the blocking handshake, which as mentioned needs to be rewritten...
For my own reference, I'm tracking more general issues that still need attention on the forked repo: https://github.com/pendulum-project/nts-timesyncd/issues
Last pushes addresses the comments and removes some of the stub elements (the non-async parts and the superfluous socket handling code). The business logic of server selection still needs to...
> Unit tests are fine, but a large feature like this needs a full system integration tests added to `TEST-45-TIMEDATE.sh` as well Is this allowed to use external services? A...