Ryan Liptak

Results 664 comments of Ryan Liptak

I'm not familiar with what the 'color modifiers tab' is. Could you provide more info? EDIT: The crash log would also be helpful.

Looks similar to the crash that was fixed in https://github.com/squeek502/AppleSkin/pull/235

Looks like the honey bottle does not set `alwaysEdible` to true for whatever reason, and instead it overwrites `use` to always return `ActionResult.CONSUME`. Likely need to special case it in...

We don't have prebuilt binaries for ARM Macs, unfortunately.

Sounds like a duplicate of https://github.com/luvit/luvit/issues/857

> Let's try change default LUVF_CALLBACK_FLAGS to LUVF_CALLBACK_NOEXIT. This just runs into https://github.com/luvit/luv/issues/433 again, see https://github.com/luvit/luv/issues/433#issuecomment-548973999 for the problem with it.

Note also that neovim does not use the default `luv_cfpcall`, so fixing the non-string error problems on our end won't actually fix them for neovim.

Surprised that our docs don't mention this; that should definitely be fixed regardless of whether we return `nil` or `"unknown"` as the type. I assume the same applies to `fs_readdir`...

Personally, I think I prefer keeping it as `nil`, or at least keeping some way of distinguishing between 'we got a type but it's unknown--it is not one of the...

Just to help me wrap my head around this, could you provide some example code showing a use-case this change allows for (e.g. before, code with callbacks would be written...