Sean Quah

Similar to #13505. Originally reported by @jplatte in https://github.com/matrix-org/synapse/pull/13509#issuecomment-1212916888: ### Description The first example on https://matrix-org.github.io/synapse/develop/admin_api/user_admin_api.html shows this: ``` "is_guest": 0, "admin": 0, "deactivated": 0, "shadow_banned": 0, ``` but some...

Enable cancellation for `POST /_matrix/client/v3/keys/query`

2

`POST /_matrix/client/v3/keys/query` can take a long time. When clients retry the request, the new request gets queued behind the previous one by `E2eKeysHandler._query_devices_linearizer`, so retrying a request that timed out...

Use a state filter or accept partial state in a few places where we request state, to avoid blocking. To make lazy-loading `/sync`s work, we need to provide the memberships...

Add APIs to edit previously sent messages

1

Sometimes it makes sense for bots to update previously sent messages instead of posting new ones. An example might be a bot providing progress updates on a long running process.

When calling `resolveRoom` or `lookupRoomAlias`, there is currently no clean way to distinguish between a non-existent room alias and other failures, which ought to be handled differently. This makes it...

`scripts/s3_media_upload` ignores media files that have been deleted, but then pulled back into the local media store

4

When (re)generating thumbnails, Synapse will ensure that the original image is in its local media store by downloading it back from storage providers. The `s3_media_upload` script does not notice when...

Complement `TestPartialStateJoin/Outgoing_device_list_updates/Device_list_updates_reach_newly_joined_servers_in_partial_state_rooms` is flakey

3

https://github.com/matrix-org/synapse/actions/runs/3172224388/jobs/5166469780#step:4:2964 ``` client.go:604: [CSAPI] GET hs1/_matrix/client/v3/sync => 200 OK (125.434036ms) federation_room_join_partial_state_test.go:1674: @t24alice:hs1's partial state join to !0:host.docker.internal:38237 completed. client.go:604: [CSAPI] PUT hs1/_matrix/client/v3/devices/PBJFBBTZIN => 200 OK (18.65378ms) federation_room_join_partial_state_test.go:1677: @t24alice:hs1 sent device...

Faster room joins: `device_lists.left` not emitted in `/sync` response when completing the join and discovering that a user is actually not in the room

2

See the commented out check in the `TestPartialStateJoin/Device_list_tracking/Device_list_no_longer_tracked_for_user_incorrectly_believed_to_be_in_room` complement test. That test case is roughly: 1. A room starts with `@charlie:remote`, `@derek:remote` (moderator) and `@fred:remote` (admin) 2. `@fred:remote` leaves the...

Faster room joins: Device list cache not flushed when it is discovered that we incorrectly thought we shared a room with a remote user for some period in the past

2

See the skipped `TestPartialStateJoin/Device_list_tracking/Device_list_tracking_for_user_incorrectly_believed_to_be_in_room_when_they_rejoin_before_the_partial_state_join_completes` complement test. That test case is roughly: 1. A room starts with `@charlie:remote`, `@derek:remote` (moderator) and `@fred:remote` (admin) 2. `@fred:remote` leaves the room. 3. `@alice:local` partial...

Faster room joins: Outgoing device list updates not sent if we leave the room before join completes

3

When a local user updates their device list while in a partial state room, their device list updates are buffered up, since it's not known for sure which servers are...