Dane Springmeyer

Results 404 comments of Dane Springmeyer

I have confirmed the git bisect of @gravitystorm - this was definitely broken in https://github.com/mapbox/carto/commit/4d4abb2. I've added (currently failing) tests now that enforce the old behavior of style/attachment order than...

pull request fixing this at https://github.com/mapbox/carto/pull/277. Hoping @tmcw can take the lead on reviewing and merging it if seems wise.

So, overall: 1) This original issue is a regression in the still unreleased/dev code of carto/tilemill - specificity should not change the order of attachments (aka Mapnik styles). 2) After...

noticing that the openstreets-dc stylesheet is still not rendering correctly with latest carto/tilemill/mapnik - looks like like it did before this fix: https://github.com/mapbox/carto/issues/247#issuecomment-18320132

re-opening, not convinced this is fixed fully or that the problem is fully understood.

these are the relevant changes between carto v0.9.3 and master: https://gist.github.com/springmeyer/5784466 Studying them now to try to reduce a testcase.

I agree that we should consider warning or throwing with "sorry opacity should only be set once per style" for the style you've provided because its not clear which wins....

@tmcw - do you think it is actionable to throw if one of these style level options is detected twice inside a single attachment?

logging for later reflection: as per my comment at https://github.com/mi1980ge/cardboardMap/commit/a7d37bcb2228d514d674a957fd57dd4a8a389223#commitcomment-3823331, it looks like when two `image-filters` are applied they are concatenated. the last should likely win, but needs more thought.

@stevage thanks for reporting and helping narrow this down. Getting a backtrace out of the core dump would be ideal, since it should show where the crash is happening. That...