Dane Springmeyer

Results 403 comments of Dane Springmeyer
trafficstars

👋 @zmofei - would you be interested in taking this on? 2 parts: a) updating to latest mbgl and b) documenting the process of doing it.

Thanks for reporting @kylebarron - This will be fixed by #44

@artemp nice catch. Can you try to track down what change in node core fixed what you are seeing? Also, could this explain https://github.com/mapbox/vtshaver/pull/40 ?

> Also, could this explain #40 This btw seemed to me like a v8 behavior rather than node core or Nan related, but I'm not positive.

thanks @artemp - I feel pretty good about #40 as a workaround, but let me know if you see a better one.

> ideally we shouldn't use v8 methods from N-api module. Ah, good point.

This is passing on travis except for the coverage build, which I'm working on fixing over at #29 /cc @ian29 @mapsam

This PR is now rebased against latest master and includes the latest mapbox-gl-style-spec release, which means its ready for further review and testing /cc @ian29 @ericfischer @mapsam

This PR came up today in conversation with @briandaviddavidson. The main holdup on moving this forward is that we need to build confidence around `styleSpec.convertFilter`. I don't yet know the...

> so I'm now just checking if (cpinfo.distance == 0.0) and assuming it is a truthy PIP hit. @mapsam that feels like a good solution to me. One thing I...