Spring Projects Issues

Results 1565 comments of Spring Projects Issues

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be...

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

**[Rossen Stoyanchev](https://jira.spring.io/secure/ViewProfile.jspa?name=rstoya05-aop)** commented Indeed the HTML Unit integration for Spring MVC Test doesn't support async requests currently. We'll have to revisit that for 5.0.

**[Rossen Stoyanchev](https://jira.spring.io/secure/ViewProfile.jspa?name=rstoya05-aop)** commented `ServerRequestUriComponentsBuilder` has methods to build from a request instance. Considering that `UriComponentsBuilder.fromHttpRequest` already exists what else would `WebFluxUriComponentsBuilder` have besides a `fromServerRequest(ServerRequest)` method? Note that we will...

**[Rossen Stoyanchev](https://jira.spring.io/secure/ViewProfile.jspa?name=rstoya05-aop)** commented An alternative idea is something like `ServerRequest.relativeToRequestUri` returning `UriComponentsBuilder`.

**[Arjen Poutsma](https://jira.spring.io/secure/ViewProfile.jspa?name=arjen.poutsma)** commented Initial version committed at https://github.com/spring-projects/spring-framework/commit/a7617a264120ca486d7c92bb4255ec1ac3ef986e. As discussed, [Rossen Stoyanchev](https://jira.spring.io/secure/ViewProfile.jspa?name=rstoya05-aop) will add subsequent `@Controller-related` methods.

**[Rossen Stoyanchev](https://jira.spring.io/secure/ViewProfile.jspa?name=rstoya05-aop)** commented [Arjen Poutsma](https://jira.spring.io/secure/ViewProfile.jspa?name=arjen.poutsma) taking a quick look, for `WebFluxUriComponentsBuilder` to have `@Controller` methods its current location could be an issue. `MvcUriComponentsBuilder` by comparison in is in the same...

**[Arjen Poutsma](https://jira.spring.io/secure/ViewProfile.jspa?name=arjen.poutsma)** commented ??Since what is needed for ServerRequest is a trivial one-liner, could we find another solution perhaps? ServerRequest has a uri() method. What about a uriComponentsBuilder next to...

**[Arjen Poutsma](https://jira.spring.io/secure/ViewProfile.jspa?name=arjen.poutsma)** commented Done, see https://github.com/spring-projects/spring-framework/commit/1a3cc3df94c0f8e504f36e9be8e6f2ded5a12750