Pranav S

Results 23 comments of Pranav S

Hi, I have written a fix for this, PR #837. I noticed that fdot is a parameter, although it does not need a keyword to be passed. The description of...

Hey @JoseAntonioSiguenza I've added a function to add support for CIF files. Can you take a look?? P.S. I ran a formatting tool which changed a bunch of lines, I'll...

I have made the changes. Before I commit, should I make a separate module for astropy_support? As for the test case, I was thinking we could generate an images like...

Yes okay, I'll keep that in mind :) I can't think of a name for the module, so I have just named it astropy_support for now. Also, I have added...

I made the formatting changes. I am confused about the testing, though. As there is no reference image, `tox -e py311-test-image-mpl360-cov` is failing, and `tox -e py311-test-image-mpl360-cov -- --mpl-generate-hash-library=astropy/tests/figures/py311-test-image-mpl360-cov.json` is...

Two checks are exected to fail I believe, and two others are giving this message- _______ [doctest] astropy.visualization.astropy_support.astropy_support ________ 008 009 Enable support for plotting `astropy.units.Quantity` and `astropy.time.Time` instances in...

I used `.. plot::` as used in other docstrings, and it works. Is there anything?

@neutrinoceros Now only the new image test CI is left. Once that's sorted the PR should be good to go right? I would like to contribute more. Please let me...

The `py311-test-image-mpldev-cov` was failing. I updated the JSON file for the same. Now the check is passing. The hash is same as the one generated on CircleCI, thus the tests...

Yes, I agree. Astropy support should be reserved for broader application anyway...