Bob Aman
Bob Aman
Good point. I agree.
These should definitely be made consistent. Since we likely can't easily influence the behavior of `IDNA::Native`, I'm inclined to believe it should be considered the canonical result where behavior is...
I like this idea, but I'd like to see documentation updated for the methods that would start accepting anything that responds to `[]` as well as some `responds_to?` type checking...
Sorry BTW about the really late reply, somehow the email notification for this PR slipped through the cracks.
Also interested in @therabidbanana's take on this PR.
@levinalex I like this change, but I'd like to see at least one more test covering the "anything else that responds to `[]`" scenario as well as a documentation update,...
I think it's worth calling out that Addressable's `heuristic_parse` does aim to hew quite closely to whatever browsers are doing in the address bar. The `parse` function should probably not...
I'd have to consider this, because it's an `extract` call instead of an `expand` call, it's a little less straight-forward. @therabidbanana, thoughts?
I like the second proposal, though I'd probably want to see it be a bit more intelligent about which component things are being extracted from. For instance, the path component...
The bug here is with `leave_encoded`. See http://intertwingly.net/blog/2004/07/31/URI-Equivalence and referenced discussion for why this behavior is correct in the absence of `leave_encoded`.