Filippe Spolti
Filippe Spolti
IIRC there is something similar in the ce-arq: https://github.com/jboss-openshift/ce-arq/blob/79ad6a9319d4fcaf3f85bde17e581a8982c97781/utils/src/main/java/org/jboss/arquillian/ce/utils/Containers.java https://github.com/jboss-openshift/ce-arq/blob/8c598c8880316c031a6319b6e60ab62affc6930b/utils/src/main/java/org/jboss/arquillian/ce/adapter/AbstractOpenShiftAdapter.java#L178
Do you think we should keep it on both places?
That's right, the problem is if there is no definitionsFile to be processed the Observer on TemplateContainerStarter.waitForDeployments (IMHO the routesAdd could be here instead BuildablePodCube) is not triggered, not sure...
@lordofthejars I updated the PR, it now will wait for all resources and create the routes properly with or not the definitionsFile, or if there is only the definitionsFile.
I'll rebase it and try to add some tests. Thanks and sorry for the delay.
Hey @lordofthejars / @jwendell can you please take a look?
Sounds good to me, but the issue I got was that, if you have a env called A=B and override the env A to the value C, the final Dockerfile...
I agree, cache reuse is really good. For now, we will need to find way to trim/optimize how the modules are being installed.
your diff are adding only commented lines, is this correct?
yeah, as you stated, those copy instructions only copy module.yaml files. I didn't understand what you said here: > The one remaining concern I have with this is if there...