Mathew Heard

Results 344 comments of Mathew Heard

@jasnell It would be my hope too that it would be made easier. Thanks for confirming the current state though. I can manage that. I'll convert my testing app from...

Feature detection isnt working with quictls/openssl 3.0.0beta2+quic the QUIC flag is in quic.h not crypto.h Flag is the same so all I did was swap `crypto.h` for `quic.h` in getsharedopensslhasquic.py

@jasnell No luck building on the latest new-quic branch ``` /build/node/out/Release/.deps//build/node/out/Release/obj.target/libnode/gen/src/node/inspector/protocol/NodeRuntime.o.d.raw -c ../src/quic/buffer.cc: In constructor 'node::quic::JSQuicBufferConsumer::JSQuicBufferConsumer(node::Environment*, v8::Local)': ../src/quic/buffer.cc:333:39: error: 'PROVIDER_JSQUICBUFFERCONSUMER' is not a member of 'node::AsyncWrap' 333 | : AsyncWrap(env,...

@jasnell A clean build still fails ``` ../src/quic/buffer.cc:333:39: error: 'PROVIDER_JSQUICBUFFERCONSUMER' is not a member of 'node::AsyncWrap' 333 | : AsyncWrap(env, wrap, AsyncWrap::PROVIDER_JSQUICBUFFERCONSUMER) {} | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/quic/buffer.cc: In constructor 'node::quic::StreamSource::StreamSource(node::Environment*, v8::Local)':...

@jasnell what version of OpenSSL is this supposed to be built with?

@jasnell @danbev thanks for the update I can confirm that now that the instructions in my dockefile build this PR. Havent done any testing yet.

@jasnell Fails to build on 32-bit. ``` "../src/quic/session.cc:374:6: error: no declaration matches ‘void node::quic::Session::CryptoContext::AcknowledgeCryptoData(ngtcp2_crypto_level, uint64_t)’", " void Session::CryptoContext::AcknowledgeCryptoData(", " ^~~~~~~", "In file included from ../src/quic/endpoint.h:9,", " from ../src/quic/session.cc:3:", "../src/quic/session.h:569:10: note:...

I reviewed. There still looks to be 32bit issues. Basically size_t is not always 64bit. There is implicit casting going on e.g in calls to AcknowledgeCryptoData (parameter datalen)

@jasnell any updates on this?

I can confirm that @jasnell your latest commits now build on x86, armv7 (32bit) and of course x86_64. First bug found too. When responding with responseWith from the server the...