Andreas Gohr
Andreas Gohr
Thanks for the list. The picks are a good start, we can always discuss/change certain choices in their respective PRs. I thinks starting with the non-toolbar icons is easiest. The...
It seems the HTTPS environment variable isn't set. Which is curious. I guess we could also check for the protocol in the REQUEST_URI... https://github.com/dokuwiki/dokuwiki/blob/5719588d0f688f7f6046619e9d8a8df7aba77ef6/inc/init.php#L535-L547
The Arial based font stack has been picked deliberately, because back in the day Arial was one of the only fonts covering nearly all of the Unicode supported scripts. IIRC...
I'd love to have these flaky tests fixed. If it's as simple as @Klap-in says and its simply the clock accidentally ticking a second further it would be an easy...
That approach is okay, but the important part is to check and understand the involved code first. To make sure that it is indeed correct that the timestamp can be...
I managed to reproduce the flaky test locally by being very very patient: ``` while ./phpunit.phar tests/inc/common_saveWikiText.test.php --filter savesequence5 ; do :; done ``` Above call will repeat the test...
Its okay to report it here since dokuwiki.org is affected, even though this is indeed a problem in the installed plugins. Most probably the data plugin.
I am not sure how to implement that, pull request welcome.
quoting myself here: > pull request welcome
> Especially with Jack Jackrum, incompatible plugins have become a major issue how so? I don't see how Jack Jackrum should be much different from earlier releases in that regard....