Neil Williams

Changing the body of a response object after the baseplate tween has run causes no content to be returned

1

Between v1.4 and v1.5, Pyramid applications that map an exception to a view (`@view_config(context=MyException)`) lost the ability to control the body of the response. In fact, the body appears to...

We don't generally consider IDL-specified Thrift exceptions as span failures (since they're generally equivalent to a 4xx in HTTP terms -- they're part of a valid response rather than an...

https://github.com/reddit/baseplate.py/blob/develop/baseplate/frameworks/queue_consumer/kafka.py#L77 This sleep is inside a server span so it's subject to timeouts. That doesn't seem right since it's kinda on the outside of the event loop.

Warn when choosing invalid metric names

1

If a span is named something that doesn't make a valid metric path component, it can cause the metrics related to it to get discard. For example, a redis pipeline...

Explicitly mark private code with underscore prefixes

1

This will allow better flexibility for library maintenance in the future and make it clearer to users which interfaces are stable and which are internal. Once done, we can also...

In Kubernetes, who "owns" the memory of a message queue? Who should? If the service, how do we ensure it doesn't get OOM'd because a sidecar isn't consuming messages?

Add helpers for IDs

1

To ensure we have standard processing of reddit IDs (which look suspiciously like r2 fullnames).

https://docs.pylonsproject.org/projects/hupper/en/latest/

`baseplate-{script,serve}` already hide gevent monkeypatching, so it'd be nice to do the same for psycogreen monkeypatching if sqlalchemy+PG is in use.

Figure out what's wrong with config.Optional(config.DictOf)

7

DictOf does what we want without Optional but the combo confusingly always returns the default. This may just be something that we detect and say "don't do that" since it's...