SplaTAM icon indicating copy to clipboard operation
SplaTAM copied to clipboard

Fix a 'bug' in prune_gaussians func

Open jeezrick opened this issue 1 year ago • 2 comments

Change to prune Gaussians when there actually is any point need to remove.

The old version will do remove_points even when to_remove is all false, which will discard all gradients by calling remove_points function, which leads to a waste of optimizing iteration.

This happens (almost) every 1st iter in mapping. You can check it by running 'replica/splatam_s.py'. The number of gaussians didn't change after prune, but the gradient is gone.

jeezrick avatar Feb 23 '24 02:02 jeezrick

And the result is actually better because of the 1 more iter of mapping. image

jeezrick avatar Feb 23 '24 02:02 jeezrick

I'm not sure I get this. Could you share more details?

Also I don't see any big discrepancy in numbers?

Nik-V9 avatar Mar 15 '24 00:03 Nik-V9