spenke91

Results 14 comments of spenke91

I created a draft PR #1732 removing the `forest` argument from the adapt callback (but not yet the `deprecated `keyword). As you can see in the changed files [there](https://github.com/DLR-AMR/t8code/pull/1732/files), in...

> thanks for looking into this. Imho in these use cases it should be fine switching to putting the user data on to `forest_from`. The purpose of the user data...

I looked a little bit into how to treat `forest->user_data` and `forest->t8code_data` once we remove the `forest` argument from `t8_forest_adapt_t`. In principle, all test cases are running fine if I...

Thank you for finding this! I looked into the files manually to see the end of line characters. Once CI is green (and the typo pointed out above by @Davknapp...

I moved the issue to "In Review" because @Davknapp is already reviewing it.

@sandro-elsweijer @lukasdreyer Do you agree that this issue is fixed and can be closed? I checked it locally and heard from others that it works for them too...

Thanks a lot for your contribution @dutkalex ! I am out of office this week, but looking forward to reviewing it next week 👍

AMR meeting: Maybe CMake modules might be interesting / helpful?

@ole-alb @lukasdreyer Are there preferences on what a unified name should be? `elements`, `leaves`, or `leaf_elements`? 🤔