Spencer Long comments

Results 38 comments of


                                            Spencer Long

Use `htmlentities()` instead of `htmlspecialcharacters()` on Custom Field Listbox Values

> Also looks like we have 8.1.1 failing test? Looks like flakey test, re-ran and it passed. > I'd love to see some tests here, and also some proofs that...

Use `htmlentities()` instead of `htmlspecialcharacters()` on Custom Field Listbox Values

@snipe So, turns out that the actual problem here is that on the initial `store` of a custom field the value isn't escaped - but it _is_ once it's `update`d,...

Use `htmlentities()` instead of `htmlspecialcharacters()` on Custom Field Listbox Values

Alright, so, fixed the problem with the escaping on update, so we now save unescaped raw input on both store and update. Then realized that blade's echo helper already does...

Use `htmlentities()` instead of `htmlspecialcharacters()` on Custom Field Listbox Values

@snipe friendly poke

Use `htmlentities()` instead of `htmlspecialcharacters()` on Custom Field Listbox Values

@snipe friendly poke

Manage EOL date by checkbox of eol_explicit

I'll work on getting this reviewed this week. Thanks @Robert-Azelis!

New asset checked out to user also sets current location

Confirmed bug, should have a PR open by the end of the day.

Add new validator for custom field checkboxes and fix asset model default updates

@snipe friendly poke

Add new validator for custom field checkboxes and fix asset model default updates

per @snipe adding some validation for radio buttons as well, please hold

Add new validator for custom field checkboxes and fix asset model default updates

alright, added @snipe