Spencer

Results 30 comments of Spencer

When closing the db connection, I followed Java's try-with-resources design approach of capturing suppressed errors. https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html#suppressed-exceptions

Submitted another PR to address the hanging issue. https://github.com/gimenete/dbdiff/pull/18

> are all error results in the telemetry event exceptions? Passing the error through `Exception.normalize/2` will take care of any cases where it is not an exception. ```elixir iex(11)> Exception.normalize(:error,...

> Yes, but your code isn't accounting for if it is an exception or not, it just records an exception no matter what in the current implementation. How can we...

> Yes, but your code isn't accounting for if it is an exception or not, it just records an exception no matter what in the current implementation. How can we...

> I'm not sure if any of them are going to return an exception struct as the second value in the error tuple. You can see from the augmented test...

> @spencerdcarlson to be clear, does that above code that matches out an exception case work for your use-case and you see the error in datadog? Yes, I believe so....

> I'm just thrown off by Ecto returning exceptions as errors. That's the default behavior of Ecto/[[Postgrex](https://hexdocs.pm/postgrex/Postgrex.html#execute/4)|[MyXQL](https://hexdocs.pm/myxql/MyXQL.html#execute/4)] Here are a few examples of common exceptions that would be nice to...

@mx-psi here are some redacted (just being overly cautions) screenshots of how I see the issue. All the error traces related to `opentelemetry_ecto` only display `error: true`. The error status...

> What do you mean by "but it is not associated to the trace."? That information is somewhere in the Datadog UI but just not shown in the span tags?...