Geoffrey MUSELLI comments

Results 40 comments of


                                            Geoffrey MUSELLI

feat: ApplicationSet Go template

@crenshaw-dev I solved merge conflicts

feat: ApplicationSet Go template

@crenshaw-dev it seems that there is a problem in integration tests. Could you please check ?

Using unofficial Tesseract4 PPA instead of compiling it

Hello, I first thought about using it. However if you look at the package details: https://launchpad.net/~alex-p/+archive/ubuntu/tesseract-ocr/+packages You can see that the unoficial package is not building on both version (xenial...

Using unofficial Tesseract4 PPA instead of compiling it

Ok thx for your help. I will make a try this evening with your dockerfile and if it is working I will create a PR

Using unofficial Tesseract4 PPA instead of compiling it

Hello @minyk It seems to work. So you can proceed to a PR :) A recap of the Dockerfile FROM ubuntu ENV GOPATH /opt/go # Get git golang and gcc...

feat: Support alias for helm repo in application source

Look good to me. I will take one last look when tests are fixed, For the e2e you need to change the name of your tests. They are used to...

feat: Support alias for helm repo in application source

Would need a code owner approval

fix(14903): Appset in any namespace crashes due to RBAC

@crenshaw-dev I confirm with ClusterRole everything is working. I also tested this version without ClusterRole on a test cluster and everything looks good.

fix(14903): Appset in any namespace crashes due to RBAC

I will try to handle it next week

fix(14903): Appset in any namespace crashes due to RBAC

The code is ready. I am just waiting for a gentle review 🙂