fix(14903): Appset in any namespace crashes due to RBAC

[speedfl]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Fixes [ISSUE #14903]"

@crenshaw-dev @jannfis Trying to formalize the PR for this issue

Checklist:

• [x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• [x] The title of the PR states what changed and the related issues number (used for the release note).
• [x] The title of the PR conforms to the Toolchain Guide
• [x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• [x] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• [x] Does this PR require documentation updates?
• [x] I've updated documentation as required by this PR.
• [ ] Optional. My organization is added to USERS.md.
• [x] I have signed off all my commits as required by DCO
• [x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• [x] My build is green (troubleshooting builds).
• [x] My new feature complies with the feature status guidelines.
• [x] I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 49.47%. Comparing base (f87897c) to head (1dac1fb). Report is 43 commits behind head on master.

:exclamation: Current head 1dac1fb differs from pull request most recent head a3f9e79. Consider uploading reports for the commit a3f9e79 to get more accurate results

Files	Patch %	Lines
...cationset/controllers/applicationset_controller.go	0.00%	23 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #14914      +/-   ##
==========================================
- Coverage   49.73%   49.47%   -0.27%     
==========================================
  Files         274      271       -3     
  Lines       48948    47821    -1127     
==========================================
- Hits        24343    23658     -685     
+ Misses      22230    21823     -407     
+ Partials     2375     2340      -35     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[crenshaw-dev]

I'm gonna go ahead and cut 2.8.0, and then we'll work on this. For now folks can either use a ClusterRole or wait for this PR

[speedfl]

@crenshaw-dev I confirm with ClusterRole everything is working.

I also tested this version without ClusterRole on a test cluster and everything looks good.

[pezzking]

why is this PR taking so long? We are all waiting for fix because in 2.9.2 its still an issue when running namespace-install.yaml

E1124 18:19:54.286526       7 reflector.go:138] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:167: Failed to watch *v1alpha1.Application: failed to list *v1alpha1.Application: applications.argoproj.io is forbidden: User "system:serviceaccount:argocd:eaglenest-argocd-application-controller" cannot list resource "applications" in API group "argoproj.io" at the cluster scope

[speedfl]

I will try to handle it next week

[pezzking]

long week my friend :)

[clementlecorre]

Any news ?

[kozmagabor]

@speedfl Do you have any chance to handle this in the next couple of weeks? thanks!

[speedfl]

The code is ready. I am just waiting for a gentle review 🙂

[Tyrael]

@crenshaw-dev any chance you could get this one reviewed?

[quercus-carsten]

Hi, first: thanks @speedfl for fixing this. I am also waiting for this to be reviewed. Can't wait go ahead with appsets in any namespace soon! @crenshaw-dev :)