serverless-benchmarks icon indicating copy to clipboard operation
serverless-benchmarks copied to clipboard

feat: Knative deployment support

Open octonawish-akcodes opened this issue 1 year ago • 5 comments

Fully supported Knative serverless platform Integration PR cc @mcopik

Summary by CodeRabbit

  • New Features

    • Introduced cloud event handlers for Node.js and Python in Knative.
    • Added MinIO storage handling for Node.js and Python.
    • New configurations for Knative deployments in systems.json.
    • Added documentation for Knative deployment and configuration.
  • Bug Fixes

    • Ensured proper formatting in requirements.txt during package addition.
  • Chores

    • Automated Kind cluster setup with Knative via knative_setup.sh.
  • Documentation

    • Detailed instructions for setting up and deploying Knative in SeBS platform.

octonawish-akcodes avatar Jun 20 '24 06:06 octonawish-akcodes

there are two things I want to discuss with you on wrappers and code packaging, Since the func deploy command automatically creates the function image, do we need to create the base image like we have for openwhisk, and func create creates files which includes several other files like req.txt, some bash script file, afaik and tested the main file is func.py and func.yaml so how should I package the code?

octonawish-akcodes avatar Jul 02 '24 11:07 octonawish-akcodes

[!NOTE]

Reviews paused

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Walkthrough

The update introduces comprehensive support for Knative within the SeBS platform, featuring new cloud event handlers, MinIO storage interactions, deployment configurations, and extensive testing capabilities. The changes span Node.js and Python environments, providing robust functionality for event handling, storage, and deployment automation.

Changes

File(s) Change Summary
benchmarks/wrappers/knative/nodejs/index.js, benchmarks/wrappers/knative/nodejs/storage.js Added cloud event handler and MinIO storage interaction class for Node.js.
benchmarks/wrappers/knative/python/func.py, benchmarks/wrappers/knative/python/storage.py Introduced main function for request handling and MinIO storage interaction class in Python.
config/systems.json Added Knative configurations for Python and Node.js environments.
docs/platforms.md Added deployment and configuration instructions for Knative within SeBS.
sebs/benchmark.py Enhanced package writing in add_deployment_package_python method by appending newline characters.
sebs/knative/config.py, sebs/knative/function.py, sebs/knative/knative.py, sebs/knative/triggers.py Introduced Knative system management classes and methods for configuration, function management, and triggers.
sebs/regression.py Added classes for regression testing specific to Knative for both Python and Node.js.
tools/knative_setup.sh Script to automate setup of a Kind cluster with Knative and Kourier, along with a local container registry.

In Knative's bright, new day, Functions deploy in a seamless way. With Node and Python, they rise, Benchmarking under clear skies. Storage flows with MinIO's grace, All in one, it finds its place. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jul 04 '24 13:07 coderabbitai[bot]

@coderabbitai pause

mcopik avatar Jul 19 '24 11:07 mcopik

Actions performed

Reviews paused.

coderabbitai[bot] avatar Jul 19 '24 11:07 coderabbitai[bot]

This current changes makes all the benchmarks run on knative platform with redeployments, Need final reviews here :)) @mcopik @oanarosca

octonawish-akcodes avatar Aug 02 '24 11:08 octonawish-akcodes