rFaaS icon indicating copy to clipboard operation
rFaaS copied to clipboard

ReaderWriterQueue and Update README

Open omcal opened this issue 11 months ago • 2 comments

#14 Add ReaderWriterQueue and Update README

  • Integrated ReaderWriterQueue as a dependency via the CMake build system.
  • Updated README to acknowledge the use of ReaderWriterQueue and Pistache.
  • Note: Additional testing may be required to ensure proper integration.

omcal avatar Mar 17 '24 19:03 omcal

@omcal Thank you for this contribution!

One question: what do you mean by: "Note: Additional testing may be required to ensure proper integration."? Did you build rFaaS and verified that we properly have everything linked and included?

mcopik avatar Mar 20 '24 15:03 mcopik

Yes, I did in my local but since there is no CI/CD i was not sure about that :D so I added that note And Thank you for your response @mcopik

omcal avatar Mar 20 '24 16:03 omcal

@oisildak Hi! I see you deleted the repository. Unfortunately, the PR slipped through the cracks.

I will test it locally and recreate the PR from your commit. It would be best to have this commit as your authorship and contribution - in that case, please recreate the PR with this commit :)

mcopik avatar Jun 13 '24 11:06 mcopik