rFaaS icon indicating copy to clipboard operation
rFaaS copied to clipboard

Add dependency on read-writer queue

Open mcopik opened this issue 3 years ago • 4 comments

We should add readerwriterqueue as a proper dependency in the CMake build. Furthermore, we want to fetch and build Pistache to avoid the trouble of forcing users to install it manually.

  • [ ] Fetch the dependency with CMake.
  • [ ] Ensure that include directories are properly configured.
  • [ ] Add in the README proper acknowledgment of the other project.

mcopik avatar Nov 14 '21 23:11 mcopik

I'll try to file a pr for this, but I'm wondering how to handle versioning of the library

Yuanmxc avatar Mar 22 '23 03:03 Yuanmxc

@Origin-yy I think we can fetch the tag corresponding to the lastest release. You can also compare it against the version we included in our code to check if there are any potential incompatibilities.

mcopik avatar Mar 22 '23 15:03 mcopik

I am new to open source development, but I'm eager to learn and contribute to resolving this issue.

Mac16661 avatar Sep 11 '23 17:09 Mac16661

@Mac16661 I recommend starting with looking at CMake FetchModule - we want to use that to add the library as a component :-)

mcopik avatar Sep 11 '23 17:09 mcopik