dace icon indicating copy to clipboard operation
dace copied to clipboard

Fixed a Possible Bug in the Extended State Fusion

Open philip-paul-mueller opened this issue 7 months ago • 2 comments

The variable connections_to_make was a class variable and not marked as a dace property and hence shared between all instances. It is now an instance variable and thus private. Also the variable was never cleared, so technically, the connections should have accumulated inside it.

Furthermore, the transformation assumed that can_be_applied() was called immediately before apply(), because the can_be_applied() function populates the connections_to_make. However, this behaviour is not guaranteed and now apply() explicitly calls can_be_applied() to make sure that connections_to_make is properly populated.

philip-paul-mueller avatar May 15 '25 13:05 philip-paul-mueller

I am not fully sure how a unit test for that thing would look like, as it essentially would be a test that there is no (observable) state, between two invocation of the same object.

philip-paul-mueller avatar Jul 17 '25 14:07 philip-paul-mueller

@acalotoiu What's the status here, are we still waiting for something on this PR?

phschaad avatar Nov 04 '25 07:11 phschaad