dace icon indicating copy to clipboard operation
dace copied to clipboard

Consider data descriptor offset when propagating memlets

Open lukastruemper opened this issue 2 years ago • 5 comments

This PR adds the data descriptor's offsets to the memlet propagation.

lukastruemper avatar Nov 29 '23 20:11 lukastruemper

@Sajohn-CH I saw the same issue in one of my fortran examples and found a fix. I added your code as a new tests.

https://github.com/spcl/dace/issues/1372

lukastruemper avatar Nov 29 '23 20:11 lukastruemper

@acalotoiu I thought we were removing/deprecating offsets?

tbennun avatar Nov 30 '23 16:11 tbennun

@acalotoiu I thought we were removing/deprecating offsets?

Lex explained that they will solve it in the frontend. I simply didn‘t know that we also deprecate it. Then we could close the PR

lukastruemper avatar Nov 30 '23 16:11 lukastruemper

@acalotoiu I thought we were removing/deprecating offsets?

Yes - but while we intend to do that, actually removing them is not an engineering effort planned for the short or medium term. I propose we allow the fix for the current state for now.

acalotoiu avatar Dec 01 '23 21:12 acalotoiu

LGTM

@tbennun merge?

lukastruemper avatar Jan 06 '24 23:01 lukastruemper