Benedikt Franke

Results 403 comments of Benedikt Franke

I am not planning to implement such functionality in Lighthouse myself, but am open to accepting PRs.

Just noticed this is a duplicate of https://github.com/nuwave/lighthouse/issues/1214. An implementation attempt was also started https://github.com/nuwave/lighthouse/pull/1253

@andershagbard right, there is some overlap between the issue, but the intent is different. > Could this be solved by implementing a select directive? That would be one part of...

We might do that as an MVP. I am a bit worried about migrating big applications towards optimized selects, but maybe it is not a big issue in practice. I...

> @spawnia I am working on an implementation for this, and I am having trouble accessing child directives via `$resolveInfo`. Accessing the directives property on any selection in a selectionSet...

I do not know what you mean by *parent* or *child* directives. Consider the `FieldValue` class and its uses, maybe you will find what you need there. Try posting a...

Regarding namespaces: We should use them where they line up with the structure of the GraphQL schema. Types fall within the root GraphQL namespace and thus should not be put...

> Just a question - do accessors (like `getPhoneNumberAttribute()`) count to "default resolver"? Yes, the default resolver calls them through simple property access on the `$root`. I like your suggestions...

> 'queries' => 'App\GraphQL\Types\Query', The next major version of Lighthouse could actually drop explicit namespaces for the root type fields, so that line would not even be in `lighthouse.php` anymore....

We have documentation about this, see https://lighthouse-php.com/master/performance/query-caching.html#query-caching. Using `php artisan cache:clear` is admittedly quite coarse, it clears the entire cache every time. I don't think we should include that in...