Ben Buchwald

Results 12 comments of Ben Buchwald

I appreciate #7155 and that is how I was intending to fix this issue when I came here to submit an issue/PR. However, when I searched to find this issue,...

> How about we let the methods return `NotImplemented` and let operators skip over it? I like this suggestion. You are right that `NotImplemented` is truthy so this is more...

Good catch. I had actually originally implemented as raising NotImplementedError and catching it, but changed to returning NotImplemented when someone suggested it. I think at this point I will probably...

@ysliaw01 It is certainly a simpler solution, and would solve the problem for many people in many cases, but I disagree that it is a better solution. If your base...

@ysliaw01 The biggest case is with NOT. Let's say I have an `IsOwner` permission that checks if the authenticated user is the owner of the object in question. This has...

Can someone please look at this PR? It hasn't been looked at in over a year and I'd really like to get permission composition working correctly. I know I'm not...

Ah, I did try to look why `has_object_permission` was implemented like that, but I failed to find that issue. That makes a lot of sense, and actually, though I haven't...

Looks like there's already an issue for this against DRF https://github.com/encode/django-rest-framework/issues/7117 . It looks like there's a PR to fix it exactly as I would have suggested (in the OR...

> From review, the approach in #6605 looks good to me. > > Could we work through seeing if there are any objections to that? I think we could also...

Yeah, this makes sense. Perhaps there is a way to monitor for interfaces becoming connected so that after you power on the switch in your example above, the interface would...