Shahar Papini

Results 24 comments of Shahar Papini

fix(formatter): incorrect exit code on files with syntax errors

Oops, I tihnk we broke main :S weird, Ill check why CI didnt stop it

fix(formatter): incorrect exit code on files with syntax errors

Seems it's not a mandatory check (the cairo-fmt check), No worries then:)

bug: files with syntax error incorrectly reported as well-formatted

lgtm

dev: make binary target names cairo/starknet specific

O think that's a good idea. Renaming crates and executables. I'd like to get such a PR. @orizi ? Wdyt? One question - generate_syntax isn't supposed to be an exposed...

dev: make binary target names cairo/starknet specific

I think every crate should be prefixed with cairo. I think we just didn't know these names correspond to package names on crates.io when we started writing.

dev: make binary target names cairo/starknet specific

This sounds good to me. Though, I don't like the dxs abbreviation. I don't mind having a long name, so I prefer `diagnostics` Other than that, would love to get...

Move transformer prenorm on the residual path

Hey. It only fails on torch backed for some reason. It passes ndarray backend. Have any clue why that might happeb?

Support for `VK_KHR_ray_tracing_pipeline`

What's the status on this? Can I help?

snippet change

* **#3761** 👈 * **#3760** * **#3759** * **#3757** * **#3756** * **#3755** * **#3754** * **#3753** * **#3752** * **#3751** * **#3750** * **#3749** * **#3748** * **#3747** *...

bug: Cast from usize to i16 failed during `apply_ap_change`

Updating here: adding revoke_ap_tracking() in the middle fixed this. We should do this in the compiler