Markus Spann

The pull request is solid and solves the problem at hand IMO. How about merging the PR and taking a spin at a possible NumberFormatter rewrite or refactoring in a...

Looks like no part at all of my PR actually made it into master. Not even the improvements to DefaultFunctionsTest.

Test `DefaultFuntionsTest.testFinancialFuncs` was failing due to Locale (due to the usage of `CStr` to be precise). The conversion to `CStr` is out of place here IMO since numerical functions are...

> as far as i can tell, all tests are now succeeding even when i change the locale. is that true for you as well? yup, tests are green under...

The `SqlStatements.templateCache` is of type `com.github.benmanes.caffeine.cache.BoundedLocalCache` which according to its Javadoc is "an in-memory cache implementation that supports full concurrency of retrievals, a high expected concurrency for updates, and multiple...

In `ReflectionMappers` the member `columnNameMatchers` is not currently thread-safe. The list reference as well as list contents change when the public setter `setColumnNameMatchers` is invoked. The getter `getColumnNameMatchers` is public,...