Markus Spann

Results 36 comments of Markus Spann

@hgschmie I cannot reproduce this issue or rather these Mockito warnings in master Likely this has resolved itself with dependency updates or other changes with (positive) side effects ;)

Hi @stevenschlansker, thanks for your feedback! > [...] I'm a little worried that changing the method signature might break binary compatibility. As `String` implements `CharSequence`, it is a (I guess...

Good morning @stevenschlansker, just rebased this PR to `master`. Saw you released yesterday, nice ;)

I have rebased this pr to master.

> @sman-81 , I still think changing the method parameter types is likely to be a problem. I am surprised that it had no compatibility concerns with Apache Commons 3....

I am not in favor of adding delegate methods, as it would be so many of them and clutter the code. Is the only way forward to apply this PR...

Hi there Steven (@stevenschlansker) > Unfortunately, I don't think we can break binary compatibility here. [...] I agree :( > I am not aware of a better solution than adding...

Hi @stevenschlansker introduction of delegate methods won't work either due to `@FunctionalInterface` such as `TemplateEngine` :( I will reduce the PR to use `CharSequence` in those places only where we...