Markus Spann

Results 36 comments of Markus Spann

Hi there @carterkozak now `String#split` is gone. I have also squashed commits into one. Please take a look.

Hard to believe my PR actually got merged after a little over 1,5 years :)

**DatabaseTest.testAncientDates** fails without my patch. Failure details: ``` Tests run: 28, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.93 sec

Hi @jahlborn, I've split test case `testAncientDates` into two methods There are really two concerns, first creates dbs and inserts on the fly, while second runs tests on a canned...

Hi @jahlborn, setting the locale to US _for all tests_ limits the value of the library's test suit IMO. `-Duser.language=en -Duser.region=US` Tests now run under US locale no matter where...

> different direction with the locale settings (i was concerned that messing with the default locale might now work reliably in a multi-threaded setting) You're concerned about the private static...

> is there a problem with the way i set the locale in the pom file? In a technical sense no. But tests now run under US locale everywhere and...

I'll try another approach how we can resolve this neatly. I will update the pr and let you know tomorrow.

Hi @jahlborn, I've taken another spin on this code. It was a bit of work but now we have a solution that I am happy with, and I hope you,...