stereo-calibration icon indicating copy to clipboard operation
stereo-calibration copied to clipboard

Added visualize.cpp to visualize chessboard corners and updated CMakeLists.txt accordingly…

Open BarunKGP opened this issue 7 years ago • 5 comments

Added visualize.cpp to visualize chessboard corners and updated CMakeLists.txt accordingly. Please review the changes made @sourishg

BarunKGP avatar Dec 14 '17 08:12 BarunKGP

Hi @BarunKGP - you don't need to create an extra file visualize.cpp to solve this issue. Just incorporate your visualization code in calib_intrinsic.cpp.

sourishg avatar Dec 14 '17 17:12 sourishg

@sourishg , I've updated calib_stereo.cpp in the latest commit. It now contains code to visualize the stereo pair if both left and right images are found.

BarunKGP avatar Dec 15 '17 04:12 BarunKGP

Hi @BarunKGP, great. Here are some of views:

  • To enable the visualization, please use some other popt variable than v, as it is already used for rightcalib_file option.
  • Use POPT_ARG_NONE as the type of your variable as it does not need an argument. Here is an excerpt from popt documentations that might help you:

If the argInfo argument type is POPT_ARG_NONE, the popt library will set arg to 1 if the option is present on the command line. You should pass a pointer to an int if you want this set for you.

  • imshow, would also need a waitKey(0) after it for the image to be actually displayed. However, it would also need the user to press a key after every frame. You can find out a way to make it more user friendly.

mpdmanash avatar Dec 18 '17 13:12 mpdmanash

@BarunKGP please update the PR as requested by @ManashRaja

sourishg avatar Dec 22 '17 07:12 sourishg

Yes, sure! I'm working on it. Will update it soon.

BarunKGP avatar Dec 22 '17 14:12 BarunKGP