defradb

defradb copied to clipboard

feat: JSON type coercion

2

## Relevant issue(s) Resolves #3097 ## Description This PR fixes JSON type coercion and makes it much simpler to filter, create, and update JSON fields. ## Tasks - [x] I...

nasdf

Bump golangci-lint linter to v1.61 and fix deprecated stuff and linter errors Also noticed the old linter panics upon running locally for me. New version works fine.

shahzadlone

Suggestion from @nasdf: https://github.com/sourcenetwork/defradb/pull/3099#discussion_r1787947741 Change: ``` go db, ok := req.Context().Value(dbContextKey).(client.DB) if !ok { responseJSON(rw, http.StatusBadRequest, errorResponse{NewErrFailedToGetContext("db")}) return } ``` To return error `500` so roughly this: ```go db, ok...

shahzadlone

Providing a new docID fails with an error as documented by `TestMutationUpdateOneToOne_RelationIDToLinkFromSecondarySide`. Setting the id field to `""` returns `malformed document ID, missing either version or cid`. Setting the id...

AndrewSisley

The JSON input type should be able to handle any valid GQL type and not just strings. This is how mutations with JSON fields currently work: ```graphql mutation { create_Users(input:...

nasdf

nasdf

nasdf

The aggregate return types are `Float`, but can also return an `Int`. Aggregate return types should be a union: `union NumericalAggregate = Float | Int`

nasdf

There is some high level info in an almanac doc here: https://source.almanac.io/folders/database-team-v1-q4qgzK/branchable-collections-Z0SmQmyPcgaYimjMlHuLZPEGM1s38Ewg?mention_id=4192&docView=Commenting WIP thoughts: - We do not need a composite for each document change, instead we only need one...

AndrewSisley

We can improve the following function in `test/integration/utils.go`: ```go func getNodes(nodeID immutable.Option[int], nodes []clients.Client) []clients.Client { if !nodeID.HasValue() { return nodes } return []clients.Client{nodes[nodeID.Value()]} } ``` To return a list...

shahzadlone