Martin Pool comments

Results 246 comments of


                                            Martin Pool

Mutate checked arithmetic

I guess this could be generalized into a mapping of function/method name replacements, but checked arithmetic would be a great place to start.

Conflicting documentation about how args and config settings are merged

Currently, `exclude_glob` (and other exclusion options) override the config file rather than appending to it, inconsistently with other options. This was intentional but I'm no longer sure it's a good...

Functions mutated to return constant with `NonZero` return value are always unviable

Hi, thanks for reporting this. I don't know if we mutate `NonZero` at all at the moment, but we probably should. And it looks like the existing mutation for `NonZeroUsize`...

docs: More information on what is and isn't included by cargo package

r? @weihanglo

docs: More information on what is and isn't included by cargo package

The failures seem to be unrelated flakes?

docs: More information on what is and isn't included by cargo package

https://github.com/rust-lang/cargo/actions/runs/11330170805/job/31507413375?pr=14684 Perhaps this is getting rate-limited based on the GitHub workers IP pool, if the cargo build does not currently pass any credentials? If so, just switching to an authenticated...