Martin Pool

Results 246 comments of Martin Pool

On the other hand perhaps this is a signal that you could try to cover that code with Miri or some similar technique. (I've never tried it; maybe it's not...

I think it's a bit of a trap for new users onboarding to the jj model, especially because putting the bookmark back on @- takes a somewhat long command. Requiring...

Yeah as the person who originally filed the bug leading to this description: I do think it can be a little confusing at first but once you acclimatize to jj,...

> Here's a discovery I made: If `@` is an empty revision that has a bookmark pointing to it, you can run `jj squash` to move it to its parent....

There is already #50 about automatically understanding that `#[cfg(windows)]` isn't useful to mutate on `!windows`. However it's also a good idea, and will be simpler to implement, to just take...

Done: https://mutants.rs/config-file.html

There are already build timeouts, in https://mutants.rs/timeouts.html?highlight=timeout#build-timeouts. Perhaps, or apparently, they're not working properly here? If you look in `mutants.out/debug.log` then you should be able to see something about how...

timeouts=Timeouts { build: None, test: Some(36s) } It seems to be not setting a timeout to kill the process, and relying on rustc's internal detection of long running const eval....

Thanks for digging into this. We primarily rely on rustc's built in detection of long running const eval. But maybe this doesn't catch long-running proc macros, so we might need...

>In a recent [release](https://github.com/sourcefrog/cargo-mutants/releases/tag/v24.7.1) it appears that the default for build timeouts was removed. Yes, I took out the default because it seemed hard to calculate a reasonable default, and...