Eric Pederson

Results 61 comments of Eric Pederson

Hi @Quincunx271 - what's the status of this? I tried using the `Catch.cmake` and `CatchAddTests.cmake` from your partial implementation (https://github.com/Quincunx271/Catch2/blob/3047ee81052b35f9867b61c15a81c9df2b539621/contrib/CatchAddTests.cmake) with CMake 3.21.0, but when I run `ctest` I get...

I got it working with this fix: ``` diff --git a/contrib/CatchAddTests.cmake b/contrib/CatchAddTests.cmake index b2a4d886..a91c9ea7 100644 --- a/contrib/CatchAddTests.cmake +++ b/contrib/CatchAddTests.cmake @@ -110,9 +110,9 @@ function(get_tags OUT) list(APPEND test_list "${prefix}${test}${suffix}") endforeach() -...

Ahh - I see what you mean about the `APPEND`. It looks like maybe there is a CMake bug with `set_property TEST APPEND PROPERTY LABELS`. The test names are already...

Got it working ``` $ ctest --print-labels Test project /home/eric/work/tw-base/cmake-build-debug All Labels: Admin AsyncSuccess AsyncTimeout Async ... (many more) $ ctest -L RequestResponse Test project /home/eric/work/tw-base/cmake-build-debug Start 68: service:Relay Envelope...

Seems to work ok with CMake 3.16.2, even with tags with spaces in them. What is a case that would break pre-3.18 that the "CMake upstream issue" fixes?

Ok - I'll add `get_test_property`. Is there any backwards-compatibility logic that will need to be added for pre-3.18 CMake versions?

I was starting to think about joining the result of `get_test_property` but realized that each test is being added (via `add_test`) in the same `exe_tests-SHA1.cmake` in which we are adding...

I see, ok. `get_test_property` coming... :)

I tried the `get_test_property` route in the generated code, for example: ``` get_test_property( [==[utils:Binary Encoding]==] LABELS test_labels) set_tests_properties( [==[utils:Binary Encoding]==] PROPERTIES LABELS Binary Pack ${test_labels}) ``` But CMake failed with...

I tested with CMake versions back to CMake 3.4.3. Where there are multiple test executables that `catch_discover_tests` are called for then the label support (including test names and tags with...