soumitra-st

Results 9 comments of soumitra-st

Thanks @john-bodley for your comments. IMO, the PR is fixing a bug not breaking existing functionality. Wondering why is it a breaking change? I tested the changes using `pinotdb==5.2.0` and...

@john-bodley I checked internally, the latest pinotdb module supports Pinot version 1.1.0, and we have merged the PR to update the version [here](https://github.com/python-pinot-dbapi/pinot-dbapi?tab=readme-ov-file#python-db-api-and-sqlalchemy-dialect-for-pinot).

I work in StarTree and volunteer to help resolve the issue. Found why the `CREATE CHART` is disabled for Pinot: 1. Button is disabled [HERE](https://github.com/apache/superset/blob/master/superset-frontend/src/SqlLab/components/ExploreResultsButton/index.tsx#L40) if allows_subquery is not defined...

Testing out changes in my local setup, I will create a PR soon.

Thanks @betodealmeida for suggestion, let me create the PR and we can iterate on that to improve the user experience.

Created JIRA - https://issues.apache.org/jira/browse/ZOOKEEPER-4760

> Please create a Jira for this and describe the feature mentioning which version branch would you like it to be added. I think this is suitable for `master` and...

> breaking window for 5.0 opens @john-bodley , shall we merge this PR as it is? If not, what is the timeline for 5.0 release?