patrick

Results 270 comments of patrick

> Yes, absolutely. But I don't understand: how does whether `extensions` supports 3.12 or not affect whether you can use 3.12 for other things? Yes, we are trying testing HLS...

> Fixed by #96 and uploaded to Hackage as https://hackage.haskell.org/package/extensions-0.1.0.2. Please let me know whether that works. Thank you for the fast action, we are currently blocking by more https://github.com/haskell/haskell-language-server/issues/4219....

It seems my recent PR created a conflict here. I am going to fix it now

`canonicalizePath` is blocking, should make path absolute before `canonicalizePath`

Stan is blocking https://github.com/soulomoon/haskell-language-server/blob/2ebfafcea751adb8d0be9c1ad9c40a4f8771f261/plugins/hls-stan-plugin/src/Ide/Plugin/Stan.hs#L144 > -- Note that Stan works in terms of relative paths, but the HIE come in as absolute. Without > -- making its path relative, the...

The ghcide-tests seems to be running faster now, run under 3m50s in ghc9.6

@konn thanks for the review ! @fendor I've implement the `TestConfig` you mentioned at https://github.com/haskell/haskell-language-server/pull/4207#discussion_r1597660237. See if this part look good?

Thanks for the detailed review and suggestions @fendor The following have been done. 1. added a Note. 2. aligned coding style. Does it look good ?

Again, thank your for the reviews and suggestions, expecially since this PR contains a lot of changes, you have done me a great favor of tracking everything down ! I...

>Just some more attention to the Note, I still don't quite get the LSP root thingy, where does this affect us? `LSP root` is deprecated, @michaelpj send me the link,...