haskell-language-server icon indicating copy to clipboard operation
haskell-language-server copied to clipboard

Support for 9.10

Open wz1000 opened this issue 1 year ago • 3 comments

This includes supports for all plugins, other than formatters and hlint.

We need ghc-exactprint and retrie release before landing this.

  • [x] boring https://github.com/phadej/boring/pull/45
  • [x] indexed-traversable: https://github.com/haskellari/indexed-traversable/pull/42
  • [x] witherable https://github.com/fumieval/witherable/pull/103
  • [x] ghc-trace-events https://github.com/maoe/ghc-trace-events/pull/15
  • [x] co-log-core https://github.com/co-log/co-log-core/pull/41
  • [x] constraints-extras https://github.com/obsidiansystems/constraints-extras/pull/55
  • [x] hie-bios https://github.com/haskell/hie-bios/pull/435
  • [ ] HieDb https://github.com/wz1000/HieDb/pull/75
  • [ ] retrie: https://github.com/facebookincubator/retrie/pull/64
  • [ ] floskell: https://github.com/ennocramer/floskell/pull/82
  • [ ] stylish-haskell: https://github.com/haskell/stylish-haskell/pull/480

wz1000 avatar May 15 '24 11:05 wz1000

If anyone wants to help, chasing up any of the allow-newers would be helpful (get upstream to release/make a revision).

michaelpj avatar May 15 '24 12:05 michaelpj

I've revised the lsp packages

michaelpj avatar May 17 '24 11:05 michaelpj

It seems my recent PR created a conflict here. I am going to fix it now

soulomoon avatar May 27 '24 14:05 soulomoon

Can we start turning things off so we can merge this? The PR is getting quite big now.

michaelpj avatar Jun 08 '24 06:06 michaelpj

Just pushed the fix to last non-retrie related failing tests (cabal plugin), So I guess we would just need to disable retrie plugin related stuff? CC @wz1000

jhrcek avatar Jun 08 '24 12:06 jhrcek

Somehow the build is failing on macos with a weird linker error?

michaelpj avatar Jun 11 '24 13:06 michaelpj

fourmolu got released, trying to add that now

michaelpj avatar Jun 12 '24 09:06 michaelpj

The plugin doesn't compile and it's not 100% obvious how to fix it, so reverting to add later.

michaelpj avatar Jun 12 '24 10:06 michaelpj

I made a GHC issue for the linker problem: https://gitlab.haskell.org/ghc/ghc/-/issues/24982

It's also reproducible if we just bump the index-state: https://github.com/haskell/haskell-language-server/pull/4315

michaelpj avatar Jun 12 '24 12:06 michaelpj

:shipit:

michaelpj avatar Jun 13 '24 14:06 michaelpj