soruh
soruh
Great, I agree. I'll implement that when I'm home then.
[07f754b](https://github.com/dani-garcia/vaultwarden/pull/3147/commits/07f754b8b10bdb1105e921523b7917d2fe34c01b) adds the check. If you think the check for executability is too complicated I can remove it again.
I have just pushed [82452b3](https://github.com/dani-garcia/vaultwarden/pull/3147/commits/82452b3b2f8b49275f99e0048ce50217088be484) which adds the check using the `which` crate. If there is a consensus on what to do we can either revert it for the old...
I feel like it would be unfortunate for this to get stuck on something that feels pretty minor to me. I would really like this to be in the next...
Do you know if there is a way for github to automatically squash PR commits or should I clean up the commit history a bit?
Thank's alot for your help on this @BlackDex!
Curious that git thinks there is a conflict here. I think it assumes my new function is the same as the function added on main. I've rebased it now...
[done](https://github.com/dani-garcia/vaultwarden/discussions/2450#discussioncomment-4950651)
Thank you! I think it would help to have tests available for users to test their own `Storage` implementations against. (Similar to what I attempted here: https://gitea.h.glsys.de/soruh/validate_omnipaxos_storage). This could be...