soruh
soruh
I attempted this and implemented/ignored the brunt of the stupid clippy complaints [here](https://github.com/danieleades/tree-buf/pull/1).
That seems reasonable, thank you for the quick response
@jonhoo > it seems unfortunate to hold the lock for the entire bin just to get mutable access to one value. We won't need to, since every item in the...
Hmm, you're right, requiring `V: Clone` seems unfortunate. Maybe we can apply the idea I had of using the `BinEntry` variant as a kind of lock to the entry API,...
> I think there are some adjustments missing here: > > https://github.com/dani-garcia/vaultwarden/blob/9991563573ea43b997da47a62bbb83669c667462/src/config.rs#L1046-L1049 Fixed in [41faff5](https://github.com/dani-garcia/vaultwarden/pull/3147/commits/41faff5ec789df635d6af9b65ffd0eea73617757)
Oh, I missed that. Might be because it was hidden :)
Thank you, that's a good point. I'll add that when I get home.
It looks like the `SENDMAIL_COMMAND` is ultimately passed into tokio::process::Command so if it's an absolute path it will just be executed but if it's not it will be looked up...
A third option would be to actually iterate through the PATH as suggested [here](https://stackoverflow.com/questions/37498864/finding-executable-in-path-with-rust/37499032#37499032) but that doesn't seem reasonable to me.
I think I would prefer forcing an absolute path