Jonas Termansen comments

Results 37 comments of


                                            Jonas Termansen

Missing unsigned char libc interface semantics

I commented a bunch on the commit, found a bunch of issues. These kind of bugs will give weird third party software failures in the future. I can't comment on...

Missing unsigned char libc interface semantics

strncat is also wrong for that matter.

Missing unsigned char libc interface semantics

strstr looks wrong, it doesn't backtrack after a failed partial match. It's possible to do this correctly in O(N) time efficiently, might want to look up knuth morris pratt or...

Missing unsigned char libc interface semantics

I suggest adding abort or something to memcpy in case of overlapping copies, at least ind ebug builds, it'll help catch undefined behavior cases.

Missing unsigned char libc interface semantics

strndup doesn't check for malloc failure.

Missing unsigned char libc interface semantics

strtok_r is suspicious. The use of strchr there is very inefficient. I suggest you use strspn.

[CP] Imports can't be found by analyzer inside a bazel workspace

This commit has been cherry-picked in 2.18.0-271.7.beta (0283de5506a5bd7d0e63e2092bf53ec93adddbd1).

[CP] "Directory watcher closed unexpectedly" on Windows during Flutter builds

This commit has been cherry-picked in 2.18.0-271.7.beta (0283de5506a5bd7d0e63e2092bf53ec93adddbd1).

Directory.list() should allow skipping hidden files

The Unix case is easily implemented in user code by handling files starting with a period specially. The Windows case is the most useful as it's a separate file attribute...

[Request] OpenCL and/or CUDA support for VVIS and VRAD.

The VBSP, VVIS, VRAD source code in the SDK should correspond to the actual binaries. At least, my Linux port of these tools seem to work entirely as expected. If...